Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape single quote (') characters as ' #35

Closed
RyanGlScott opened this issue Sep 15, 2018 · 0 comments
Closed

Escape single quote (') characters as ' #35

RyanGlScott opened this issue Sep 15, 2018 · 0 comments
Labels

Comments

@RyanGlScott
Copy link
Contributor

Currently, stache escapes only four of the five XML entities that need to be escaped, as it does not escape single quotes (') as '. (Alternatives include ' and ', but they aren't as widely supported on as many browsers as '.)

I originally noticed this because microstache (a fork of stache) does not escape single quotes when substituting into criterion's HTML report, which is the root cause of this bug.

(Credit goes to JustusAdam/mustache#28 for this idea.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants