refactor: remove updateDirtyFlag and expose checkDirty

stackblitz · Jan 24, 2025 · 430fa2b · 430fa2b
1 parent 3a6b0bd
commit 430fa2b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 26 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -27,7 +27,7 @@ interface WriteableSignal<T> {
 const {
 	link,
 	propagate,
-	updateDirtyFlag,
+	checkDirty,
 	startTracking,
 	endTracking,
 	processEffectNotifications,
@@ -175,12 +175,11 @@ function notifyEffect(e: Effect) {
 	const flags = e.flags;
 	if (flags & SubscriberFlags.Dirty) {
 		runEffect(e);
-	} else if (flags & SubscriberFlags.Pending) {
-		if (updateDirtyFlag(e, flags)) {
-			runEffect(e);
-		} else {
-			processPendingInnerEffects(e);
-		}
+	} else if (checkDirty(e.deps!)) {
+		runEffect(e);
+	} else {
+		e.flags = flags & ~SubscriberFlags.Pending;
+		processPendingInnerEffects(e);
 	}
 }
 

diff --git a/src/system.ts b/src/system.ts
@@ -237,25 +237,7 @@ export function createReactiveSystem({
 			}
 			sub.flags &= ~SubscriberFlags.Tracking;
 		},
-		/**
-		 * Updates the dirty flag for the given subscriber based on its dependencies.
-		 * 
-		 * If the subscriber has any pending computeds, this function sets the Dirty flag
-		 * and returns `true`. Otherwise, it clears the PendingComputed flag and returns `false`.
-		 * 
-		 * @param sub - The subscriber to update.
-		 * @param flags - The current flag set for this subscriber.
-		 * @returns `true` if the subscriber is marked as Dirty; otherwise `false`.
-		 */
-		updateDirtyFlag(sub: Subscriber, flags: SubscriberFlags): boolean {
-			if (checkDirty(sub.deps!)) {
-				sub.flags = flags | SubscriberFlags.Dirty;
-				return true;
-			} else {
-				sub.flags = flags & ~SubscriberFlags.Pending;
-				return false;
-			}
-		},
+		checkDirty,
 		/**
 		 * Updates the computed subscriber if necessary before its value is accessed.
 		 *