Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default stackableVersion to operator version #493

Merged
merged 6 commits into from
Aug 3, 2023
Merged

feat: Default stackableVersion to operator version #493

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6aa311b
feat: Default stackableVersion to operator version
sbernauer Aug 2, 2023
d587c77
changelog
sbernauer Aug 2, 2023
fa2cdc3
fixup docs
sbernauer Aug 2, 2023
25f052b
charts
sbernauer Aug 2, 2023
4b9d700
Update CHANGELOG.md
sbernauer Aug 3, 2023
eb07276
cargo update --package serde --precise 1.0.171
sbernauer Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Added

- Default stackableVersion to operator version ([#493]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this needs a more prominent warning that this is a CRD change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any suggestion of what it could look like? Its non-breaking btw ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-breaking but will require people to update their CRD

Suggested change
- Default stackableVersion to operator version ([#493]).
- CRD Change: Default stackableVersion to operator version ([#493]).
While this is non breaking it changes the X field from Y to Z because it now FOO.
You will need to deploy a new CRD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked if it's valid Markdown but something along those lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are on vacation, and @siegfriedweber needs this PR to continue his work I would go with my proposed entry. We can continue discussing it here, after we reach a conclusion we need to change it in all operators anyway (so one operator more does not make a big change)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to resolve this for merging, reopening it afterwards


[#493]: https://github.com/stackabletech/nifi-operator/pull/493

## [23.7.0] - 2023-07-14

### Added
Expand Down
Loading