Use the type field to determine if ingest is collection or item #492
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalgran
force-pushed
the
jcw/use-type-when-ingesting
branch
from
7dd0587 to
94a37ed
Compare
philvarner
reviewed
May 8, 2023
1 task
The `type` field is required in STAC API 1.0.0 and using that field is preferable to a heuristic based on other field values. Connects #486
Co-authored-by: Phil Varner <pvarner@element84.com>
jwalgran
force-pushed
the
jcw/use-type-when-ingesting
branch
from
ec0dc9e to
0f625ed
Compare
|
Thanks for the text correction on the CHANGELOG, @philvarner. I accepted that change and rebased this PR on top of |
philvarner
approved these changes
May 9, 2023
philvarner
approved these changes
May 9, 2023
philvarner
approved these changes
May 9, 2023
philvarner
approved these changes
May 9, 2023
philvarner
approved these changes
May 9, 2023
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
typefield for Collection/Item determination rather than field heuristic #486Proposed Changes:
typefield is required in STAC API 1.0.0 and using that field is preferable to a heuristic based on other field values.PR Checklist: