Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to add a self link column #15 #20

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add an option to add a self link column #15 #20

merged 1 commit into from
Jul 19, 2023

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Jul 19, 2023

Implements #15

@m-mohr m-mohr requested review from cholmes and TomAugspurger July 19, 2023 08:52
@m-mohr m-mohr linked an issue Jul 19, 2023 that may be closed by this pull request
Include link to original STAC as top level property? #15
Closed
TomAugspurger
TomAugspurger reviewed Jul 19, 2023
View reviewed changes
stac_geoparquet/stac_geoparquet.py Show resolved Hide resolved
stac_geoparquet/stac_geoparquet.py Show resolved Hide resolved
stac_geoparquet/stac_geoparquet.py Show resolved Hide resolved
stac_geoparquet/stac_geoparquet.py Show resolved Hide resolved
TomAugspurger
TomAugspurger approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Do you have merge privileges here? If so, merge when you're ready.

@m-mohr m-mohr merged commit 35aa16e into main Jul 19, 2023
@m-mohr m-mohr deleted the self_link branch July 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

@cholmes cholmes Awaiting requested review from cholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include link to original STAC as top level property?
2 participants
@m-mohr @TomAugspurger