Create configuration file option #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Apr 12, 2022
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
gadomski
reviewed
Apr 13, 2022
stac_check/lint.py
Outdated
Comment on lines
46
to
47
| with open(default_config_file) as f: | ||
| default_config = yaml.load(f, Loader=yaml.FullLoader) |
There was a problem hiding this comment.
If STAC_CHECK_CONFIG isn't set, and stack-check.config.yml doesn't exist in the user's current working directory, this will error, no?
You might need to use something like pkg_resources to include the configuration file in the installed package (one example of using pkg_resources in such a way is here: https://github.com/stactools-packages/noaa-c-cap/blob/main/src/stactools/noaa_c_cap/utils.py).
There was a problem hiding this comment.
Good call! I think it's fine now with the MANIFEST.in file. Thank you
|
lgtm, but I'll defer to Pete's approval |
gadomski
approved these changes
Apr 13, 2022
|
@gadomski awesome thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76