Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectionExtension.crs_string #548

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Add ProjectionExtension.crs_string #548

merged 2 commits into from
Jul 12, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jul 9, 2021

Related Issue(s): None

Description: This can be used to feed, e.g. rasterio's CRS.from_string without having to worry about which projection field is set.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

This can be used to feed, e.g. rasterio's CRS.from_string without having
to worry about which projection field is set.
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #548 (17d94fb) into main (12eff70) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   94.25%   94.27%   +0.02%     
==========================================
  Files          71       71              
  Lines       10263    10290      +27     
  Branches     1072     1077       +5     
==========================================
+ Hits         9673     9701      +28     
+ Misses        422      420       -2     
- Partials      168      169       +1     
Impacted Files Coverage Δ
pystac/extensions/projection.py 98.49% <100.00%> (+0.12%) ⬆️
tests/extensions/test_projection.py 100.00% <100.00%> (ø)
pystac/extensions/base.py 92.45% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12eff70...17d94fb. Read the comment docs.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding this. Let's add a CHANGELOG entry for this as well and then it's good to merge.

@gadomski
Copy link
Member Author

Done.

@duckontheweb duckontheweb merged commit 073aad2 into stac-utils:main Jul 12, 2021
@gadomski gadomski deleted the feature/projection-crs-string branch July 12, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants