-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and tests for Version, Label, and File Info extensions #442
Update docs and tests for Version, Label, and File Info extensions #442
Conversation
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 89.76% 90.67% +0.90%
==========================================
Files 40 40
Lines 5150 5105 -45
==========================================
+ Hits 4623 4629 +6
+ Misses 527 476 -51
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Noticing that the sphinx autodoc output is getting quite messy with the fully qualified types in the signatures. Looked into how to use short names a bit but came up empty.
Yeah, I was thinking that, too. I tried setting the Once Sphinx 4.1 hits, it looks like we might be able to take advantage of the |
Tracked in #446 |
Related Issue(s):
Description:
Version Extension
File Info Extension
FileExtension
a concrete class on Assets since the spec only defines properties on AssetsLabel Extension
Added constants for all property names, changed the bodies of many of the property methods to rely on type checking for input validation, and used
get_required
andget_opt
more consistently.Other
PR Checklist:
scripts/format
)scripts/test
)