Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on item.set_self_href(None) for items with relative asset hrefs #291

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

lossyrob
Copy link
Member

@lossyrob lossyrob commented Mar 24, 2021

Description:
Currently if you call set_self_href on an Item with None as the parameter, if that item has assets with relative hrefs, the logic that attempts to ensure relative asset hrefs remain valid when switching the item href ends up throwing an error. This change makes it so that, if you are setting the item self href to None, any relative asset hrefs are left as is.

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@lossyrob lossyrob merged commit e0768a8 into develop Mar 24, 2021
@matthewhanson matthewhanson deleted the fix/rde/item-set-self-href-none branch March 26, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant