Merge develop into 0.5 branch for 0.5.4 release #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change suggested by @lossyrob For testing, it was easier to add __eq__ to Publication.
Checked type hints with pytype, but mypy does not agree.
Fixes flake8 error: pystac/extensions/scientific.py:110:12: F402 import 'link' from line 19 shadowed by loop variable
It's just a wrapper around str that isn't critical.
- Use pystac.Thing rather than from pystac import thing - Drop the regex checks of DOI - Remove TODO about links that was in the wrong place
layout.py: extra_fiels -> extra_fields
Implement SAT extension.
Add support for the scientific extension.
catalog.py: Be more strict with CatalogType in save()
Fix unexpected behaviour of `generate_subcatalogs`
…openended Collection TemporalExtent can be open ended
Fix source URL in README
Get eo bands defined in assets only
Previously only link href types (absolute vs relative) were modified as part of the `Catalog.save` process based on the catalog types: for ABSOLUTE_PUBLISHED, all link hrefs were made absolute, etc. The asset HREFs were not modified, which was counter to the expected result outlined in stac-utils/stactools#31. This change causes asset HREFs to also be changed to absolute or relative based on the catalog type. Note that if the asset HREF cannot be made relative, e.g. the asset HREF points to an HTTP location and the item is being stored locally, then the HREF is left unchanged.
Make asset HREFs relative or absolute based on CatalogType during save
Update CHANGELOG; version 0.5.4
Add scientific extension add to CHANGELOG.
Codecov Report
@@ Coverage Diff @@
## 0.5 #254 +/- ##
==========================================
+ Coverage 93.73% 94.00% +0.27%
==========================================
Files 30 32 +2
Lines 3749 3969 +220
==========================================
+ Hits 3514 3731 +217
- Misses 235 238 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.