-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Pointcloud extensions #176
Conversation
oh no my builds failed!? |
oh flake issues, will fix |
There we go! |
I have been running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is looking good. There's a couple of small things mentioned inline.
There's a comment on considering whether or not statistics
and schemas
should be represented by their own objects. This happens in other extensions, and I think has a benefit of consistency and usability when constructing objects for properties. However I can also imagine some downsides, so happy to talk this through or lean on your experience as a user of the extension to decide which way to go with it.
One other thing - could you add a CHANGELOG entry? This feature will be released in 0.5.3 which currently doesn't have a section, so you could create one for this 'Added' feature.
Thanks @lossyrob for the comments. I'll get on them all this week as a i have time |
…jection extension to define a proj
…d with the non breaking json
…adds tests for each.
Ok i've resolved the comments and this extension is feeling pretty good. Sorry it took me so long to get to this. Now i just need to look at why the PR checks failed. |
Looks great, thanks! |
This PR adds support pointclouds as an item extension (https://github.com/radiantearth/stac-spec/tree/master/extensions/pointcloud).
Example usage:
This work was done as part of STAC Sprint #6 and all tests are passing. Open to any suggestions or changes on this as well.