Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.9 #1384

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Remove python 3.9 #1384

merged 2 commits into from
Aug 5, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Aug 2, 2024

Description:

Numpy ended support Apr 05, 2024. We've done these in MINOR releases in the past, so if https://github.com/stac-utils/pystac/milestone/37 requires a MAJOR we'll want to get a MINOR out w/ this change first, I reckon.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Numpy ended support Apr 05, 2024
@gadomski gadomski requested a review from jsignell August 2, 2024 19:54
@gadomski gadomski self-assigned this Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (65ea9a9) to head (aa81156).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   91.07%   91.28%   +0.21%     
==========================================
  Files          51       51              
  Lines        7070     7220     +150     
  Branches     1012     1018       +6     
==========================================
+ Hits         6439     6591     +152     
+ Misses        451      450       -1     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

docs/installation.rst Show resolved Hide resolved
@gadomski gadomski added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit c77412e Aug 5, 2024
20 checks passed
@gadomski gadomski deleted the remove-python-3.9 branch August 5, 2024 17:03
gadomski added a commit to stac-utils/pystac-client that referenced this pull request Aug 6, 2024
gadomski added a commit to stac-utils/pystac-client that referenced this pull request Aug 6, 2024
gadomski added a commit to stac-utils/pystac-client that referenced this pull request Aug 8, 2024
@gadomski gadomski mentioned this pull request Aug 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants