Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the label extension #1270

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Deprecate the label extension #1270

merged 1 commit into from
Oct 23, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 19, 2023

Related Issue(s):

Description:

I kept the hooks in place (__init__.py) because the label extension adds a new object link rel type, "source". Removing that hook would change behavior, so we keep it until we make a breaking change to remove the extension altogether.

I also removed the label extension from all tutorials, and added some notebook-required dependencies to the doc optional dependency group.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 19, 2023 14:24
@gadomski gadomski self-assigned this Oct 19, 2023
@gadomski gadomski force-pushed the issues/1249-deprecate-label branch 2 times, most recently from a2804b2 to 7e2a8e1 Compare October 19, 2023 14:46
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pystac/__init__.py 94.91% <100.00%> (+0.27%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@gadomski gadomski force-pushed the issues/1249-deprecate-label branch from 00b8f1e to a8c3cb0 Compare October 20, 2023 13:43
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this

@gadomski gadomski added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit ce21599 Oct 23, 2023
18 checks passed
@gadomski gadomski deleted the issues/1249-deprecate-label branch October 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the label extension
2 participants