Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include href when schema resolution fails #1263

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Include href when schema resolution fails #1263

merged 2 commits into from
Oct 13, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 13, 2023 •
edited
Loading

Related Issue(s):

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell October 13, 2023 14:19
@gadomski gadomski force-pushed the issues/622-bubble-up-404-urls-jsonschema branch from 514b7b6 to 39eae9c Compare October 13, 2023 14:19
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pystac/validation/__init__.py 87.67% <100.00%> (+0.34%) ⬆️
pystac/validation/stac_validator.py 83.01% <100.00%> (+5.01%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@gadomski gadomski self-assigned this Oct 13, 2023
jsignell
jsignell approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

@gadomski gadomski added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 59d1868 Oct 13, 2023
@gadomski gadomski deleted the issues/622-bubble-up-404-urls-jsonschema branch October 13, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bubble up exception in validators.resolve_from_url
2 participants
@gadomski @jsignell