Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest fixtures #948

Open
pjhartzell opened this issue Jan 12, 2023 · 2 comments
Open

Use pytest fixtures #948

pjhartzell opened this issue Jan 12, 2023 · 2 comments
Labels
enhancement tests Issues or pull requests that relate to the test suite
Milestone
v2.0

Comments

@pjhartzell
Copy link
Collaborator

Since pystac is switching to pytest for testing (#939), we should look at using pytest's fixtures.
@gadomski gadomski added enhancement tests Issues or pull requests that relate to the test suite labels Jan 12, 2023
@jsignell
Copy link
Member

Just a note that the fixtures currently defined in conftest.py start with test_ which is have pretty non-standard naming. I think something like default_item or simple_item or even just item would be more typical.

gadomski added a commit that referenced this issue Feb 21, 2023
@gadomski
refactor, tests: remove test_ from fixtures
0ddad8b 
#948 (comment)
@gadomski gadomski mentioned this issue Feb 21, 2023
Merged
5 tasks
gadomski added a commit that referenced this issue Feb 22, 2023
@gadomski
refactor, tests: remove test_ from fixtures
f7b7b9d 
#948 (comment)
@gadomski
Copy link
Member

Another note: per #1001 (comment), we should find meaningful names for each test fixture that is created from the test cases. Right now the test cases are numbered 1-8, but if we dig in to each test case, we should be able to come up with a more descriptive name that makes it clear what scenario(s) test case is trying to exercise.

@gadomski gadomski mentioned this issue Feb 23, 2023
Merged
5 tasks
@gadomski gadomski mentioned this issue Apr 11, 2023
Merged
5 tasks
gadomski added a commit that referenced this issue Oct 13, 2023
@gadomski
refactor(tests): modernize version extension tests
3326b78 
- #993
- #948
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
@gadomski
Update version extension (#1262)
7bf4f6e 
* refactor: normalize import style

#1259

* refactor(tests): modernize version extension tests

- #993
- #948

* feat: add experimental to version ext

* feat: version is optional in version extension

* refactor: test import naming, ext

* feat: catalog extensions

* refactor: import style

* feat: add history media type

* feat: separate BaseVersionExtension

* feat: impl migration

* doc: fixups

* chore: update changelog

* fix(tests): mark some extra vcrs

* fix: pop_if_none on deprecated
@gadomski gadomski added this to the v2.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tests Issues or pull requests that relate to the test suite
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@gadomski @jsignell @pjhartzell