Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml instead of setup.py #501

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Use pyproject.toml instead of setup.py #501

merged 1 commit into from
Apr 28, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 27, 2023

Related Issue(s):

  • This should unblock CI for currently failing PRs by fixing the min requirements check

Description:

Also includes:

  • Bump to the min python-dateutil version to bring it into line w/ our doc dependencies
  • Adding @gadomski as a maintainer
  • Remove the unused, undocumented validation extra
  • Rework the min_requirement CI check

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added this to the 0.7.0 milestone Apr 27, 2023
@gadomski gadomski requested a review from jsignell April 27, 2023 12:55
@gadomski gadomski self-assigned this Apr 27, 2023
@gadomski gadomski force-pushed the pyproject-toml branch 2 times, most recently from 3025bcb to b0d32ea Compare April 27, 2023 13:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (97f9fcf) 87.38% compared to head (b3949e5) 87.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          12       12           
  Lines         864      864           
=======================================
  Hits          755      755           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

.github/workflows/continuous-integration.yml Show resolved Hide resolved
scripts/install-min-requirements Show resolved Hide resolved
Also includes:
- Bump to the min python-dateutil version to bring it into line w/ our doc dependencies
- Adding @gadomski as a maintainer
- Remove the unused, undocumented `validation` extra
- Rework the min_requirement CI check
@gadomski gadomski enabled auto-merge (rebase) April 28, 2023 11:17
@gadomski gadomski merged commit 6e5522b into main Apr 28, 2023
@gadomski gadomski deleted the pyproject-toml branch April 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants