Smarter href construction for clients #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwehr
reviewed
Jan 17, 2023
m-mohr
reviewed
Jan 17, 2023
gadomski
force-pushed
the
smarter-root-href
branch
from
b037307 to
ff6faeb
Compare
gadomski
commented
Jan 18, 2023
Some servers require it (per #373 (comment)).
gadomski
force-pushed
the
smarter-root-href
branch
from
ff6faeb to
6f72259
Compare
gadomski
force-pushed
the
smarter-root-href
branch
from
ccb8641 to
6f72259
Compare
Geosynopsis
reviewed
Jan 19, 2023
m-mohr
approved these changes
Jan 19, 2023
Geosynopsis
reviewed
Jan 19, 2023
Co-authored-by: Abhishek Manandhar <abhishek.adams@gmail.com>
Co-authored-by: Abhishek Manandhar <abhishek.adams@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
To protect against double-slashes in constructed urls, we stripped trailing slashes from a client's self href (#373). However, as @m-mohr, some server implementations require the trailing slash. This PR removes the
rstrip("/"), and instead constructs hrefs a bit more intelligently to guard against double-slashes.Includes two tiny spelling fixes to docstrings.
PR Checklist: