Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typing in StacApiIO #229

Merged
merged 30 commits into from
Jun 8, 2022
Merged

fix typing in StacApiIO #229

merged 30 commits into from
Jun 8, 2022

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Jun 6, 2022

Related Issue(s): #189

Description:

  • fix typing in StacApiIO class

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@philvarner philvarner changed the title Pv/fix stac api io types fix typing in StacApiIO Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #229 (17209a0) into main (43b4325) will decrease coverage by 0.02%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   83.42%   83.40%   -0.03%     
==========================================
  Files          10       10              
  Lines         712      711       -1     
==========================================
- Hits          594      593       -1     
  Misses        118      118              
Impacted Files Coverage Δ
pystac_client/item_search.py 91.90% <66.66%> (ø)
pystac_client/client.py 81.25% <100.00%> (ø)
pystac_client/stac_api_io.py 84.40% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b3bd3...17209a0. Read the comment docs.

@philvarner philvarner marked this pull request as ready for review June 8, 2022 01:08
CHANGELOG.md Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pystac_client/stac_api_io.py Outdated Show resolved Hide resolved
pystac_client/stac_api_io.py Show resolved Hide resolved
@philvarner philvarner requested a review from gadomski June 8, 2022 16:29
@philvarner philvarner merged commit 6841066 into main Jun 8, 2022
@philvarner philvarner deleted the pv/fix-stac-api-io-types branch June 8, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants