Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing improvements #225

Merged
merged 7 commits into from
Jun 7, 2022
Merged

typing improvements #225

merged 7 commits into from
Jun 7, 2022

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Jun 6, 2022

Related Issue(s):

Description:

  • add several type declarations

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@philvarner philvarner requested a review from matthewhanson June 6, 2022 17:38
@philvarner philvarner marked this pull request as ready for review June 6, 2022 21:25
@philvarner philvarner requested a review from gadomski June 6, 2022 21:25
@codecov-commenter
Copy link

Codecov Report

Merging #225 (c49e2a8) into main (49de56d) will decrease coverage by 0.16%.
The diff coverage is 84.78%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   83.61%   83.45%   -0.17%     
==========================================
  Files          10       10              
  Lines         708      713       +5     
==========================================
+ Hits          592      595       +3     
- Misses        116      118       +2     
Impacted Files Coverage Δ
pystac_client/stac_api_io.py 84.54% <80.00%> (ø)
pystac_client/item_search.py 91.90% <83.33%> (ø)
pystac_client/client.py 81.48% <86.36%> (-1.42%) ⬇️
pystac_client/collection_client.py 76.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49de56d...c49e2a8. Read the comment docs.

@philvarner philvarner merged commit 945ea97 into main Jun 7, 2022
@philvarner philvarner deleted the pv/typing-improvements branch June 7, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants