Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify type requirements for search intersects parameter, update some documentation #174

Merged
merged 11 commits into from
May 26, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #146

Description:

  1. For search intersects, tighten type definitions to require str, dict, or object with geo_interface attribute. Other objects now fail. If a user wants to use another object, they have to str() it first.
  2. add better documentation about this.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

README.md Show resolved Hide resolved
@philvarner philvarner requested a review from gadomski May 26, 2022 12:48
pystac_client/item_search.py Outdated Show resolved Hide resolved
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #174 (aca4f7c) into main (a12663a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   81.26%   81.39%   +0.13%     
==========================================
  Files           9        9              
  Lines         571      575       +4     
==========================================
+ Hits          464      468       +4     
  Misses        107      107              
Impacted Files Coverage Δ
pystac_client/item_search.py 88.53% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12663a...aca4f7c. Read the comment docs.

@philvarner philvarner merged commit 28adaf1 into main May 26, 2022
@philvarner philvarner deleted the pv/update-cql-notebook-example branch May 26, 2022 14:04
@matthewhanson matthewhanson mentioned this pull request Aug 30, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants