Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CQL example notebook with latest CQL2 syntax #170

Merged
merged 2 commits into from
May 25, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #150

Description:

Update CQL2 example notebook to use prod planetary computer and use current CQL2 JSON syntax

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

Codecov Report

Merging #170 (2fde68a) into main (0b310f0) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   81.20%   81.19%   -0.02%     
==========================================
  Files           9        9              
  Lines         564      569       +5     
==========================================
+ Hits          458      462       +4     
- Misses        106      107       +1     
Impacted Files Coverage Δ
pystac_client/item_search.py 88.35% <91.66%> (-0.18%) ⬇️
pystac_client/client.py 79.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a9567...2fde68a. Read the comment docs.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some additional docs dependencies, here's what I used:

diff --git a/requirements-docs.txt b/requirements-docs.txt
index 25cc64c..bbe3d2d 100644
--- a/requirements-docs.txt
+++ b/requirements-docs.txt
@@ -1,6 +1,8 @@
 ipykernel~=6.2
 ipython~=7.27
 Sphinx~=4.1
+geopandas~=0.10.2
+hvplot~=0.8.0
 sphinxcontrib-fulltoc~=1.2
 myst-parser~=0.15.2
 nbsphinx~=0.8

@philvarner
Copy link
Collaborator Author

@gadomski great, thanks -- I had to add them to run it locally too, but I just assumed I wasn't following the setup documentation or something

@philvarner philvarner merged commit e00d5ec into main May 25, 2022
@philvarner philvarner deleted the pv/update-cql-notebook-example branch May 25, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants