-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow query parameters #118
Allow query parameters #118
Conversation
@duckontheweb this looks like a good feature addition to me for APIs that might support non-standard parameters. Was wondering what the use case is that precipitated it, is it for authentication? Can you resolve the conflicts that arose after merging the other PRs and I'll get this in to make a release today |
e414c44
to
a01f4c8
Compare
Yes, that's right. We use a
Just rebased this and pushed the changes, so you should be good to go. Thanks for the quick turnaround! |
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 79.96% 80.00% +0.03%
==========================================
Files 9 9
Lines 544 545 +1
==========================================
+ Hits 435 436 +1
Misses 109 109
Continue to review full report at Codecov.
|
Related Issue(s):
Description:
Adds a
parameters
argument toStacApiIO.__init__
,Client.from_file
, andClient.open
to allow query string parameters to be added to all requests from that instance in the same way that theheaders
argument adds headers to each request. This will make it easier for users to interact with APIs that use an API in the query string (e.g. Radiant MLHub).Note that this PR also adds
requests-mock
as a dev dependency because it seemed like a simpler way to construct unit tests for these I/O operations.PR Checklist: