Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields extension uses incorrect plural includes and excludes #689

Closed
kurtmckee opened this issue May 22, 2024 · 5 comments · Fixed by #690
Closed

Fields extension uses incorrect plural includes and excludes #689

kurtmckee opened this issue May 22, 2024 · 5 comments · Fixed by #690

Comments

@kurtmckee
Copy link
Contributor

While interacting with a STAC API using pystac-client I found that pystac-client is submitting "include" and "exclude" fields with plural keys. This doesn't match the Fields extension documentation, and didn't work against the STAC API I was interacting with:

From the Fields extension documentation's Overview:

The fields object contains two attributes with string array values, include and exclude.
kurtmckee added a commit to kurtmckee/pr-pystac-client that referenced this issue May 22, 2024
@kurtmckee
Use singular field key names: include and exclude
f9dc05c 
Fixes stac-utils#689
@kurtmckee kurtmckee mentioned this issue May 22, 2024
Merged
3 tasks
gadomski added a commit that referenced this issue May 23, 2024
@kurtmckee @gadomski
Use singular field key names: include and exclude (#690)
8f12756 
* Use singular field key names: `include` and `exclude`

Fixes #689

* Update the CHANGELOG

* tests: add vcr test for fields

---------

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@kurtmckee
Copy link
Contributor Author

@gadomski Thank you for the quick review and merge! Do you anticipate that this could be released as an 0.8.1 or 0.9.0 release, or are there additional changes in the pipeline that you'd like to wait for?

@gadomski
Copy link
Member

Should be ok as a v0.8.1, and I can try to get that out today 👍🏼

@kurtmckee
Copy link
Contributor Author

Hooray! Thank you!

@gadomski
Copy link
Member

https://github.com/stac-utils/pystac-client/releases/tag/v0.8.1

@kurtmckee
Copy link
Contributor Author

Thank you so much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use singular field key names: include and exclude kurtmckee/pr-pystac-client
2 participants
@kurtmckee @gadomski