Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CI docker builds. #235

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Fix for CI docker builds. #235

merged 6 commits into from
Jan 24, 2024

Conversation

bitner
Copy link
Collaborator

@bitner bitner commented Jan 24, 2024

The docker image for pgstac has four targets.

  • pgstacbase: This target is essentially the same as postgis/postgis with pgtap, plpgsql-check, and partman installed (which are used for testing/development, but not required for using pgstac), it is a base postgres/postgis image that is ready to install pgstac, but does not have it installed yet.
  • pgstacbase-plrust: This is the pgstacbase image that also has PLRUST installed in preparation for future development (PLRUST is not used yet).
  • pgstac: This target is the pgstacbase image with pgstac already installed at a specific version
  • pgstac-rust: This target is the pgstacbase-plrust image with pgstac already installed at a specific version

CI ran into issues with building the pgstacbase-plrust and pgstac-plrust targets. This PR does three things:

  • Update the pgstacbase-plrust target with the latest PLRUST version
  • Modify the CI release to push the pgstacbase and pgstac targets rather than the PLRUST targets as PLRUST is not used yet.
  • Update the incremental migration tests to start at v0.3.0 rather than v0.1.9 due to a breaking change in pg_partman at version 5 that has no ability to pin a version.

@bitner bitner requested a review from vincentsarago January 24, 2024 16:56
@vincentsarago
Copy link
Member

@bitner can we add those comments in https://github.com/stac-utils/pgstac/blob/main/.github/workflows/continuous-integration.yml#L48 and also add platforms: linux/amd64,linux/arm64

…y used prior to v0.3.0 introduced a breaking change with no way to pin to earlier version
@bitner bitner requested a review from vincentsarago January 24, 2024 18:35
@bitner bitner merged commit 20b00f7 into main Jan 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants