Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added view:moon_azimuth and view:moon_elevation #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Dec 20, 2023

e.g. for nighttime lights surface radiance

@m-mohr m-mohr requested a review from matthewhanson December 20, 2023 23:44
@m-mohr
Copy link
Contributor Author

m-mohr commented Dec 20, 2023

Any thoughts @jlaura?
The new fields are arrays as I thought non-Earth data may provide angles for multiple moons?

@jlaura
Copy link

jlaura commented Dec 21, 2023

I don't think it need to. My thinking echos. a discuss with @matthewhanson. Basically, a STAC item references a single spatial entity. So, an observation with two moons in it should be represented by two different STAC items with the backing data being singletons.

I think that the one-to-one mapping (spatial entity to STAC item) is really consistent then across extensions such that we do not have to propagate arrays everywhere when two singletons might be desirable (e.g., two view geometries, two AI/ML derived labels from different target body specific training data sets, etc.)

More discussion here: stac-extensions/ssys#9 on my thinking for moving in this direction and credit to @matthewhanson for starting me down this road.

@m-mohr
Copy link
Contributor Author

m-mohr commented Dec 21, 2023

@jlaura Thanks. I think I did not make my point clear enough and there was a misunderstanding, sorry. This is meant for a single capture, not necessarily on a moon:

These fields are, comparable to the sun angles, about potential influences on a capture of a single Planet. On Earth there's a single moon that "shines" on the Earth during the nigth, which might influence the image, similar to the sun during the day. Thus we have a single value here for sun related angles.
I have not really a clue, but I assumed that on other Planets there could be multiple moons that "shine" on the Planet, no? Thus I made this an array. Does this make more sense? Is this reasonable or is there only always one moon per Planet that may influence the captures on Planets?

@jlaura
Copy link

jlaura commented Dec 21, 2023

Ohhh!!! I understand. in theory yes, in practice I am not aware of any tracking like this. I do know that some folks work on lunar South Pole data where scattered light (photons bouncing off higher slope areas and then illuminating permanently shadowed regions) is a thing, but secondary reflectance from a moon onto a surface, I'm not aware of. For the outer planets, the moons are numerous, small, and far away, so I don't know that secondary illumination from those is meaningful / measurable with what instrumentation we have.

That said, I don't know that this is a bad idea as it might future proof something we aren't aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants