Skip to content

Commit

Permalink
Do not always pass --quickjump to haddock (haskell#9049)
Browse files Browse the repository at this point in the history
  • Loading branch information
FinleyMcIlwaine authored Jun 29, 2023
1 parent 1723d22 commit 7b1a693
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Cabal/src/Distribution/Simple/Haddock.hs
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ renderPureArgs version comp platform args =
$ args
else []
, ["--since-qual=external" | isVersion 2 20]
, [ "--quickjump" | isVersion 2 19, _ <- flagToList . argQuickJump $ args
, [ "--quickjump" | isVersion 2 19, True <- flagToList . argQuickJump $ args
]
, [ "--hyperlinked-source" | isVersion 2 17, True <- flagToList . argLinkedSource $ args
]
Expand Down
13 changes: 13 additions & 0 deletions changelog.d/pr-9049
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
synopsis: Do not always pass --quickjump to haddock #9049
packages: Cabal
prs: #9049
issues: #9060
description: {

6d8adf13101 caused `cabal` to always pass the `--quickjump` flag to Haddock.
Not only does this waste memory for a service that user hasn't asked for,
but also leads to a failure with Haddocks shipped with GHC 9.0 and 9.2,
which had a separate bug (fixed in later versions but not backported) when
Haddock does not pass `--quickjump` recursively to the package dependencies.

}

0 comments on commit 7b1a693

Please sign in to comment.