more precise error message when no additional text given

staabm · Dec 17, 2023 · d0ff939 · d0ff939
1 parent ac5b2bc
commit d0ff939
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/TodoByRule.php b/src/TodoByRule.php
@@ -87,13 +87,13 @@ public function processNode(Node $node, Scope $scope): array
                     continue;
                 }
 
-                // Have always present date at the start of the message.
-                $errorMessage = "Expired on {$date}";
 
+                // Have always present date at the start of the message.
                 // If there is further text, append it.
                 if ($todoText !== '') {
-
-                    $errorMessage .= ": {$todoText}";
+                    $errorMessage = "Expired on {$date}: {$todoText}";
+                } else {
+                    $errorMessage = "Comment expired on {$date}";
                 }
 
                 $wholeMatchStartOffset = $match[0][1];

diff --git a/tests/TodoByRuleTest.php b/tests/TodoByRuleTest.php
@@ -44,7 +44,7 @@ public function testRule(): void
                 19,
             ],
             [
-                'Expired on 2023-12-14',
+                'Comment expired on 2023-12-14',
                 21,
             ],
             [
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,7 +44,7 @@ public function testRule(): void @@
 ,
                 ],
                 [
-                    'Expired on 2023-12-14',
+                    'Comment expired on 2023-12-14',
 ,
                 ],
                 [
@@ Expand Down @@