Fix laziness of TagFetcher (#15)

src/GitTagFetcher.php

@@ -2,7 +2,7 @@
 
 namespace staabm\PHPStanTodoBy;
 
-final class GitTagFetcher {
+final class GitTagFetcher implements TagFetcher {
     // fetch version of the latest created git tag
     public function fetchLatestTagVersion(): string
     {

src/ReferenceVersionFinder.php

@@ -5,10 +5,10 @@
 use Version\Version;
 
 final class ReferenceVersionFinder {
-    private GitTagFetcher $fetcher;
+    private TagFetcher $fetcher;
     private string $referenceVersion;
 
-    public function __construct(string $referenceVersion, GitTagFetcher $fetcher) {
+    public function __construct(string $referenceVersion, TagFetcher $fetcher) {
         $this->referenceVersion = $referenceVersion;
         $this->fetcher = $fetcher;
     }

src/TagFetcher.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace staabm\PHPStanTodoBy;
+
+interface TagFetcher
+{
+    public function fetchLatestTagVersion(): string;
+}

src/TodoByDateRule.php

@@ -76,7 +76,10 @@ public function processNode(Node $node, Scope $scope): array
              * PREG_OFFSET_CAPTURE: Track where each "todo" comment starts within the whole comment text.
              * PREG_SET_ORDER: Make each value of $matches be structured the same as if from preg_match().
              */
-            if (preg_match_all(self::PATTERN, $text, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER) === FALSE) {
+            if (
+                preg_match_all(self::PATTERN, $text, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER) === FALSE
+                || count($matches) === 0
+            ) {
                 continue;
             }
 

src/TodoByVersionRule.php

@@ -79,7 +79,10 @@ public function processNode(Node $node, Scope $scope): array
              * PREG_OFFSET_CAPTURE: Track where each "todo" comment starts within the whole comment text.
              * PREG_SET_ORDER: Make each value of $matches be structured the same as if from preg_match().
              */
-            if (preg_match_all(self::PATTERN, $text, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER) === FALSE) {
+            if (
+                preg_match_all(self::PATTERN, $text, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER) === FALSE
+                || count($matches) === 0
+            ) {
                 continue;
             }
 

tests/AlwaysThrowingTagFetcher.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace staabm\PHPStanTodoBy\Tests;
+
+use staabm\PHPStanTodoBy\TagFetcher;
+
+final class AlwaysThrowingTagFetcher implements TagFetcher {
+    public function fetchLatestTagVersion(): string
+    {
+        throw new \RuntimeException('Could not determine latest git tag');
+    }
+}

tests/TodoByVersionRuleAlwaysThrowingFetchterTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace staabm\PHPStanTodoBy\Tests;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use staabm\PHPStanTodoBy\ReferenceVersionFinder;
+use staabm\PHPStanTodoBy\TodoByVersionRule;
+
+/**
+ * @extends RuleTestCase<TodoByVersionRule>
+ */
+final class TodoByVersionRuleAlwaysThrowingFetchterTest extends RuleTestCase
+{
+    private string $referenceVersion;
+    protected function getRule(): Rule
+    {
+        return new TodoByVersionRule(true, new ReferenceVersionFinder($this->referenceVersion, new AlwaysThrowingTagFetcher()));
+    }
+
+    public function testRule(): void
+    {
+        $this->referenceVersion = "nextMajor";
+
+        $this->analyse([__DIR__ . '/data/regularComments.php'], []);
+    }
+
+}

tests/data/regularComments.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace RegularComments;
+
+// a file comment
+
+/**
+ * @return void
+ */
+function doFoo() {
+    // inner function comment
+    $x = 1;
+}