Fix 'Invalid version constraint ">=php"' false -positive (#38)

staabm · Dec 20, 2023 · 565b264 · 565b264
1 parent 4950745
commit 565b264
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/TodoByVersionRule.php b/src/TodoByVersionRule.php
@@ -30,7 +30,7 @@ final class TodoByVersionRule implements Rule
             @?[a-zA-Z0-9_-]*\s* # optional username
             \s*[:-]?\s* # optional colon or hyphen
             \s+ # keyword/version separator
-            (?P<version>[<>=]?[^\s:\-]+) # version
+            (?P<version>[<>=]?[0-9]+[^\s:\-]+) # version
             \s*[:-]?\s* # optional colon or hyphen
             (?P<comment>.*) # rest of line as comment text
         }ix

diff --git a/tests/data/version.php b/tests/data/version.php
@@ -10,3 +10,8 @@ function doFoo():void {
 // TODO: <1.0.0
 // TODO: <1.0
 // TODO: 1.0
+
+// should not error in TodoByVersionRule
+// TODO php:8.0.0
+// TODO php:8.0
+// TODO php:8