Fix getting columns when sql mode is using ansi_quotes #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Would be great to have a unit test for the actual problem |
I agree that would be nice! I tried but couldn't really get this to work. (Various things, didn't have the php extensions installed, tried putting it in Docker, that worked, but about half the existing tests fail, don't fully understand the structure of the existing tests.) I did add the structure of what I think would be the test. Do you have some guidelines of how to proceed? Otherwise, feel free to take my code and make it work if you do have more concrete knowledge about the test setup. |
|
I will have a look into a test when time allows, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #668.