Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add php baseline support #112

Merged
merged 1 commit into from
Apr 6, 2023
Merged

add php baseline support #112

merged 1 commit into from
Apr 6, 2023

Conversation

N-Silbernagel
Copy link
Contributor

This PR adds support for .php baseline files.

Let me know if it needs more tests.

Should be similar to how PHPStan does it.
https://github.com/phpstan/phpstan-src/blob/719831d8ea0838fd0ec9b5078bdbd95a575ec884/src/DependencyInjection/ContainerFactory.php#L284

@N-Silbernagel
Copy link
Contributor Author

closes #111

@staabm
Copy link
Owner

staabm commented Mar 31, 2023 •
edited
Loading

This looks great, thank you.

Lets see whether @ruudk or @stof can confirm this works like they expect it

@staabm staabm force-pushed the php-baseline-support branch from e0ec845 to 1fbc440 Compare April 6, 2023 06:11
@staabm staabm enabled auto-merge (squash) April 6, 2023 06:12
@staabm staabm merged commit 0dcbcbe into staabm:main Apr 6, 2023
@staabm
Copy link
Owner

staabm commented Apr 6, 2023

Lets see how it goes. Thank you

@staabm staabm mentioned this pull request Apr 6, 2023
Closed
@N-Silbernagel N-Silbernagel deleted the php-baseline-support branch April 6, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-Silbernagel @staabm