-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implementing SyntheticContinuousBanditDataset #112
Merged
+6,632
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontinuous-estimators
…ontinuous-policy-learner
Other than the above minor points, LGTM! |
@nmasahiro Thanks! |
Feature: Implementing Continuous OPE Estimators
Feature: Implementing Continuous NN Policy Learner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new feature
implement
SyntheticContinuousBanditDataset
that generates synthetic data with (1-dimensional) continuous actionshttps://github.com/st-tech/zr-obp/blob/continuous-dataset/obp/dataset/synthetic_continuous.py
this class works as follows
min_action_value
andmax_action_value
, we can control the action space (\mathcal{A} = [1,10] in the above example code)tests
SyntheticContinuousBanditDataset
https://github.com/st-tech/zr-obp/blob/continuous-dataset/tests/dataset/test_synthetic_continuous.py
refactor
action_prob
topscore
in test_synthetic.pyzr-obp/tests/dataset/test_synthetic.py
Lines 313 to 315 in c77dd99