feat(metrics) - EL status 'syncing' distance above threshold #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
anatolie-ssv
approved these changes
Jan 17, 2025
zktaiga
approved these changes
Jan 17, 2025
nkryuchkov
reviewed
Jan 17, 2025
| syncDistance := max(sp.HighestBlock, sp.CurrentBlock) - sp.CurrentBlock | ||
|
|
||
| observability.RecordUint64Value(ctx, syncDistance, syncDistanceGauge.Record, metric.WithAttributes(semconv.ServerAddress(ec.nodeAddr))) | ||
|
|
||
| // block out of sync distance tolerance | ||
| if syncDistance > ec.syncDistanceTolerance { | ||
| recordExecutionClientStatus(ctx, statusSyncing, ec.nodeAddr) |
There was a problem hiding this comment.
@oleg-ssvlabs If the code doesn't enter this if, then syncDistanceGauge is observed twice: first with syncDistance value before the if and then with 0 in syncDistanceGauge.Record(ctx, 0, metric.WithAttributes(semconv.ServerAddress(ec.nodeAddr)))
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1960