Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: proposal / post_decided error #347

Closed
wants to merge 2 commits into from

Conversation

MatheusFranco99
Copy link
Contributor

Fix issue: #303

  • Changed error message and logic.
  • Updated tests.

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my thoughts for this issue were that there was too much processing going on for a decided instance. Also the fact that the same error happens for an active and a decided instance bothered.

This current fix isn't solving this and there's also a new untested error.
However, I don't think the issue is important enough to be put in priority so I'll just be closing the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants