Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link and Image popover button not working in React 17 #399

Merged
merged 1 commit into from
May 2, 2021

Conversation

iPilotte
Copy link
Contributor

@iPilotte iPilotte commented Feb 5, 2021

React 17 has made changes to event delegation,
so it'll also call _onDocumentClick when trying to toggle popover (it make popover toggle twice: off -> on -> off)
image

@iPilotte iPilotte changed the title Fix Link and Image popover button not working in React 17 Fix Popover button not working in React 17 Feb 5, 2021
@iPilotte iPilotte changed the title Fix Popover button not working in React 17 Fix Link and Image popover button not working in React 17 Feb 5, 2021
@iPilotte iPilotte force-pushed the fix-popover-not-working branch from 2daef47 to 8b7ac24 Compare February 6, 2021 02:54
@iPilotte iPilotte force-pushed the fix-popover-not-working branch from 8b7ac24 to e653a28 Compare February 6, 2021 03:10
@sanjevirau
Copy link

Please merge this as I'm facing the same problem with React 17! Thanks a lot @iPilotte @sstur

@sh4nd00
Copy link

sh4nd00 commented Feb 11, 2021

Im having the same issue. Please merge @iPilotte @sstur

@inkinkz
Copy link

inkinkz commented Feb 12, 2021

I'm having this issue too. Please merge this. Thanks @iPilotte

@nejsimon
Copy link

This solves the problem indeed. Please consider merging this PR and making a new release @sstur ! Thanks.

@inatnun
Copy link

inatnun commented Feb 12, 2021

Please merge this PR, we really need it. @sstur

@williamhoos
Copy link

@iPilotte (or anyone else) interested in some work to help build a couple bits of functionality?

@AlexeyBee
Copy link

Please merge this PR, @sstur

@aattsai
Copy link

aattsai commented Mar 21, 2021

Please merge this PR

@athanph
Copy link

athanph commented Mar 30, 2021

Getting this problem too. Please merge. Thank you.

@secrecysiu
Copy link

Please merge this PR, we really need it too and please also fix the checkOptions warning

@sstur
Copy link
Owner

sstur commented May 2, 2021

Hey @iPilotte, thanks for the fix!

@sstur sstur merged commit b6c30d9 into sstur:master May 2, 2021
@Blubagoo
Copy link

This was merged but i dont think a new version was released on npm. Can you please release a new version for us?

@RobRendell
Copy link

It seems that someone has released a forked version with the fix on NPM: https://www.npmjs.com/package/react-rte-17

Unfortunately there is no @types/react-rte-17 Typescript definition package, but Typescript users can create their own .d.ts module definition which imports the types from @types/react-rte and exports them for module react-rte-17.

@kieranbenton
Copy link

Thanks @RobRendell for the info! @sstur is it worth reaching out to @kjanoudi (who made the NPM release) and ask them to help with the main project since they're obviously able?

@sstur
Copy link
Owner

sstur commented Dec 1, 2021

This was merged but i dont think a new version was released on npm. Can you please release a new version for us?

This has gone out with v0.16.4.

@sstur sstur linked an issue Dec 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link popover stops working with react-dom 17