-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Link and Image popover button not working in React 17 #399
Conversation
2daef47
to
8b7ac24
Compare
8b7ac24
to
e653a28
Compare
I'm having this issue too. Please merge this. Thanks @iPilotte |
This solves the problem indeed. Please consider merging this PR and making a new release @sstur ! Thanks. |
Please merge this PR, we really need it. @sstur |
@iPilotte (or anyone else) interested in some work to help build a couple bits of functionality? |
Please merge this PR, @sstur |
Please merge this PR |
Getting this problem too. Please merge. Thank you. |
Please merge this PR, we really need it too and please also fix the checkOptions warning |
Hey @iPilotte, thanks for the fix! |
This was merged but i dont think a new version was released on npm. Can you please release a new version for us? |
It seems that someone has released a forked version with the fix on NPM: https://www.npmjs.com/package/react-rte-17 Unfortunately there is no |
Thanks @RobRendell for the info! @sstur is it worth reaching out to @kjanoudi (who made the NPM release) and ask them to help with the main project since they're obviously able? |
This has gone out with v0.16.4. |
React 17 has made changes to event delegation,
so it'll also call
_onDocumentClick
when trying to toggle popover (it make popover toggle twice: off -> on -> off)