This repository has been archived by the owner on Apr 29, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 517
bats_print_failed_command: Include $output if available. #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Yes! |
LGTM |
Nice! On Monday, May 4, 2015, Victor Vieux notifications@github.com wrote:
|
👍 Applied this today locally, looks cool. |
Definitely I need this merged |
Ping @sstephenson :) |
👍 |
Bump @sstephenson |
Anyone who wants to get feedback when a test fails should take a look at the discussion in #110 and the libraries that resulted from it. |
This so needs to be merged and released. It's impossible to understand why the test failed on a build server otherwise. @sstephenson |
@aluzzardi was there a reason to close this? Is this PR perhaps merged into some official fork (in the context of #150)? |
yarikoptic
pushed a commit
to neurodebian/bats
that referenced
this pull request
Aug 6, 2019
Update readme badges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking
$status
right after arun
seems to be a quite regular use case:With this change, the
$output
of run is included in case of failure, which makes debugging much easier: