-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow XDG base dir spec in install script #49
base: dev
Are you sure you want to change the base?
Conversation
hey we actually overhauled our install script - do you mind fixing conflicts? this is a good fix - we also need to update our |
Ah yes, I found the place starting @ https://github.com/sst/ion/blob/dev/pkg/global/upgrade.go#L78 to align the |
20f9cb6
to
65624ba
Compare
Ok this is ready for another review. I want to call your attention to some details which I added in the commit description about prior sst installs:
The most unexpected situation arises when a user has
In that situation, running Since it's early in the life of sst/ion I wasn't sure if you consider it important to handle this worst case situation more gracefully and want to ask your thoughts before adding extra complexity. If you're ok with just recommending a "clean install" for that situation then I think this PR is ready to merge. If you think the worst case upgrade scenario needs a better solution, I could do something easy in the upgrade command like
Thoughts? |
65624ba
to
c6a4087
Compare
c6a4087
to
9f822a0
Compare
8b21eff
to
9112e6e
Compare
9112e6e
to
b1027d3
Compare
d59f6ea
to
096d5a1
Compare
An existing install in the ~/.sst/bin dir is not removed during the `sst upgrade` command nor is the $PATH modified by `sst upgrade`. When there is an existing install of sst prior to this commit, the safest upgrade path is to: 1. delete the ~/.sst dir 2. remove ~/.sst/bin from $PATH by editing the right shell cfg file 3. rerun the install script
096d5a1
to
87976fe
Compare
#370
$XDG_BIN_HOME
as install dir and default to$HOME/.local/bin
if$XDG_BIN_HOME
doesn't existsst upgrade
command to use the same logic for determining the install dirsst upgrade
works as expectedsst
executable and manually installsst upgrade
and verify it uses the $XDG_BIN_HOME dir