Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete 'Remove Template Files' section #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete 'Remove Template Files' section #579

wants to merge 1 commit into from

Conversation

ClaytonFarr
Copy link
Contributor

the initial API / hello world infrastructure is expected and built upon in subsequent tutorial steps, starting here - https://serverless-stack.com/chapters/review-our-app-architecture.html

the initial API / hello world infrastructure is expected and built upon in subsequent tutorial steps, starting here - https://serverless-stack.com/chapters/review-our-app-architecture.html
@jayair
Copy link
Contributor

jayair commented Sep 7, 2021

I might've missed this but in this PR (#582) you are renaming MyStack.js. Are you also removing the src/lambda.js somewhere?

If not, then we can move that to the bottom part of the chapter in that PR.

@ClaytonFarr
Copy link
Contributor Author

Ah, you're right. I was originally going to suggest updating the 'Add the Function' section (https://serverless-stack.com/chapters/add-an-api-to-create-a-note.html#add-the-function) to rename src/lambda.js to the new src/create.js file needed and update the file's contents, but had forgotten.

If you think it makes sense to direct the user to create a new file and delete the boilerplate lambda instead, it may be clearer to have that delete step occur the same chapter where we repurpose and rename MyStack.js.

@jayair
Copy link
Contributor

jayair commented Sep 10, 2021

Yeah I think it makes more sense to not rename the boilerplate stack or lambda function. Just remove it. I'd suggest moving the section from this PR to the other one #582. After we create the new API we can remove the old files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants