Plumbing for more async/await work #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobslusser
requested review from
drieseng and
WojciechNagorski
as code owners
|
It looks ok but I need to test it and check a few things. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Rob-Hague
approved these changes
Jan 6, 2024
drieseng
approved these changes
Jan 10, 2024
…SH.NET into jacob/async_merge
WojciechNagorski
approved these changes
Jan 25, 2024
|
LGTM! sorry for the delay. |
|
@jacobslusser I hope this delay hasn't discouraged you. Next time I'll try to deal with your PR right away. |
All good. 😄 |
|
This issue has been fixed in the 2024.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SocketAbstraction.SendAsyncmethod for .NET6+ targets.ProtocolVersionExchange.StartAsync.SessionwithSemaphoreSlimfor future async/await work.Notes
This PR is mostly about preparation for more async/await work and proving some of the techniques.
I made the
SocketAbstractionclasspartialso we could put conditional methods in a separateSocketAbstraction.Async.csfile. Let me know if we like that pattern because I expect a lot more conditional code is coming for other classes.