Move test projects to test folder #1203
Conversation
Move global.json to root of repo. Update solution items in solution.
Move global.json to root of repo. Update solution items in solution. Update appveyor configuration/
…into move-test-projects
|
@WojciechNagorski, upgrade to version 7.0.400 of the .NET SDK? |
|
@drieseng yes you can update. Today I will not able to review this branch but you can merge it. This is a great idea. |
|
Does it make more sense to just have everything under the src/ folder? The benchmarks project is a bit ambiguous. Before merging this one, would you mind deciding on #1183 ? Would be easier to merge that one first if it's going to be. |
To clarify, I am suggesting to just delete the test/ folder and merge the "shared" tests in that folder into the UnitTest project |
|
TBH I don't care about it. For me we can have everything in /SRC, or we can split this. |
|
#1183 I would like to merge this but I didn't have time for this. |
|
I see two options:
I strongly recommend to have a test folder that groups all test-related projects. I propose to rename Renci.SshNet.Benchmarks to Renci.SshNet.PerformanceTests. |
|
Ok, thanks, I agree it is a good thing to have them separated in order to use different .editorconfig etc. On that basis the changes here are good for me. And I am happy for the benchmarks project to be renamed. |
|
Still need to decide which of the two options we want to use. |
…efined in the Directory.Build.props that is in the test folder.
|
I prefer the first option, so I think this PR is a good idea. There is a useful link https://gist.github.com/davidfowl/ed7564297c61fe9ab814 I have encountered other approaches many times and I can work with them so that's why I won't defend a specific solution. |
* Enable list directory async for net framework (#1206) * Enable ListDirectoryAsync for .NET Framework * Removed (now) unused constant. * Remove placeholder tests (#1183) * Remove placeholder tests * Move Reverse perf test to benchmarks project --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Fix integration test after moving test projects --------- Co-authored-by: Patrick-3000 <38472350+Patrick-3000@users.noreply.github.com> Co-authored-by: Rob Hague <rh@johnstreetcapital.com>
|
I've merge this PR. I wanted to revresh this PR after merging other PR. I've also had to fix integration tests, but I was unable to change this PR, even thow I've merge changes to this PR there was still conflicts. |
There was a problem hiding this comment.
Was there a reason for this? I don't think we have any dependency on a particular sdk version (other than 7.x.x or above).
Move test projects to test folder.
Move global.json to root of repo.
Update Solution Items in solution.