-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CollectionAssert in ListDirectory tests #1166
Conversation
Can you tell me in what order you got the results? |
Same for I have not looked at the implementation, but I would not expect it to do any sorting - the user can sort the files how they like. |
It needs to be checked. I don't know if it shouldn't be deterministic. |
So the directory listing functionality is the sending of a SSH.NET/src/Renci.SshNet/SftpClient.cs Line 2276 in 9f1699b
SSH.NET/src/Renci.SshNet/Sftp/SftpSession.cs Line 1196 in 9f1699b
SSH.NET/src/Renci.SshNet/Sftp/Responses/SftpNameResponse.cs Lines 27 to 44 in 9f1699b
It looks fine to me. |
ee7785e
to
314ec57
Compare
Also seen in #1220
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
These tests were failing for me because the files were coming in in a different order
Plus,
CollectionAssert.AreEquivalent
gives a nice failure message