Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition when both server and client close channel #84

Closed
drieseng opened this issue Sep 10, 2016 · 0 comments
Closed

Race condition when both server and client close channel #84

drieseng opened this issue Sep 10, 2016 · 0 comments
Assignees
@drieseng
Labels
bug
Milestone
2016.1.0

Comments

@drieseng
Copy link
Member

When both SSH.NET and a SSH server simultaneously close a channel, then we may end up sending a SSH_MSG_CHANNEL_EOF after we've sent SSH_MSG_CHANNEL_CLOSE.

This causes the SSH server to disconnect the session.
drieseng added a commit that referenced this issue Sep 10, 2016
@drieseng
Send SSH_MSG_CHANNEL_EOF and SSH_MSG_CHANNEL_CLOSE in synchronized bl…
1d6177f 
…ock.

Fixes issue #84.

Eliminate public Close() method and its use within SSH.NET.
Remove wait bool from protected Close(bool) method.
The protected Close() method will now always wait for a  SSH_MSG_CHANNEL_CLOSE if the client initiated closing the channel.
@drieseng drieseng added this to the 2016.1.0 milestone Sep 11, 2016
@drieseng drieseng added the bug label Sep 11, 2016
@drieseng drieseng self-assigned this Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drieseng drieseng

Labels
bug
Projects
None yet
Milestone
2016.1.0
Development

No branches or pull requests
1 participant
@drieseng