Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure rustfmt #200

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore: configure rustfmt #200

merged 1 commit into from
Dec 18, 2023

Conversation

louib
Copy link
Collaborator

@louib louib commented Dec 18, 2023

I've been wanting to do that for a while. The default max_width for rustfmt is 100, which results in many split lines, given the verbosity of Rust. The PR should not be too difficult to review, but you don't have to trust me. You can copy the rustfmt.toml file and run the following script, and you should get to the same result:

#!/usr/bin/env bash
files=$(find . -name '*.rs')
IFS=$'\n'; for file in $files; do
    rustfmt "$file"
done

@louib louib marked this pull request as ready for review December 18, 2023 03:11
@droidmonkey
Copy link

We use 120 in our clang format, I'm all for longer lines

@louib
Copy link
Collaborator Author

louib commented Dec 18, 2023

@droidmonkey yeah I don't mind longer lines either, we could definitely consider bumping to 120.

@louib louib merged commit ca5bf3e into master Dec 18, 2023
7 checks passed
@louib louib deleted the add-rustfmt-config branch December 18, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants