Update flate2 dependency and fix breaking change #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joern Bernhardt <joern.bernhardt@compose.us>
|
Sorry for the late response and thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with WebAssembly lately and the flate2 dependency in its currently used version
0.2seems to be problematic for wasm-pack to compile this crate. Theflate2code has been fixed and a1.0version offlate2exists.I went ahead to update it and see if anything breaks. There is one occurrence in the code where they changed the return type of a function and got rid of a
Result<X>, making a small change necessary.I guess the
Cargo.lockchanges come from the dependency updates inflate2.