Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary multi docs #84

Merged
merged 8 commits into from
May 26, 2023
Merged

Summary multi docs #84

merged 8 commits into from
May 26, 2023

Conversation

piterand
Copy link
Contributor

Preparing functions documentation.

@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #84 (294e9d1) into main (5a8658d) will decrease coverage by 0.26%.
The diff coverage is 55.31%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   66.21%   65.95%   -0.26%     
==========================================
  Files          19       19              
  Lines        1403     1410       +7     
==========================================
+ Hits          929      930       +1     
- Misses        474      480       +6
Impacted Files Coverage Δ
ammico/test/test_multimodal_search.py 51.48% <0.00%> (-1.58%) ⬇️
ammico/utils.py 88.88% <ø> (ø)
ammico/text.py 74.83% <20.00%> (-1.33%) ⬇️
ammico/multimodal_search.py 15.87% <66.66%> (ø)
ammico/summary.py 62.22% <100.00%> (ø)

@piterand piterand requested review from lkeegan and iulusoy May 23, 2023 12:08
@piterand
Copy link
Contributor Author

A new strange error appears at the installation dependencies stage in CI.

@lkeegan
Copy link
Member

lkeegan commented May 24, 2023

A new strange error appears at the installation dependencies stage in CI.

Looks like this is already fixed upstream, maybe try running the CI again: explosion/spaCy#12659

lkeegan
lkeegan approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

iulusoy
iulusoy approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@piterand piterand merged commit 5b029b5 into main May 26, 2023
@piterand piterand deleted the summary_multi_docs branch May 26, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulusoy iulusoy iulusoy approved these changes

@lkeegan lkeegan lkeegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piterand @lkeegan @iulusoy