fixed errors in documentation #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 70.81% 70.87% +0.06%
==========================================
Files 18 18
Lines 1737 1741 +4
==========================================
+ Hits 1230 1234 +4
Misses 507 507
|
iulusoy
reviewed
Nov 10, 2023
ammico/cropposts.py
Outdated
| @@ -326,12 +326,14 @@ def crop_media_posts( | |||
| # get the reference images with regions that signify areas to crop | |||
| ref_views = [] | |||
| for ref_file in ref_files: | |||
| ref_view = cv2.imread(ref_file) | |||
| ref_file_path = ref_files[ref_file]["filename"] | |||
There was a problem hiding this comment.
ref_file["filename"] should be enough
ammico/cropposts.py
Outdated
| ref_views.append(ref_view) | ||
| # parse through the social media posts to be cropped | ||
| for crop_file in files: | ||
| view = cv2.imread(crop_file) | ||
| print("Doing file {}".format(crop_file)) | ||
| crop_file_path = files[crop_file]["filename"] |
There was a problem hiding this comment.
same here, crop_file["filename"] should be sufficient
There was a problem hiding this comment.
Oh..., yeah, sure 🤦.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.