New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update #160

Merged

piterand merged 13 commits into main from documentation_update

Oct 30, 2023

Contributor

piterand commented Oct 23, 2023

No description provided.


          deleted example text, summary and faces notebooks. Add Demo to docs

79291b0

codecov bot commented Oct 23, 2023 •

edited

Loading

Codecov Report

Merging #160 (8effea7) into main (434e018) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files          18       18           
  Lines        1737     1737           
=======================================
  Hits         1230     1230           
  Misses        507      507

Files	Coverage Δ
ammico/summary.py	`66.28% <ø> (ø)`

piterand and others added 9 commits

October 24, 2023 11:40


          fixed ammico.rst and index.rst

cd6407d


          changed cp to soft link

3c8bbe5


          changed readme and demonotebook for documentation

0cfea1c


          removed soft link and cp command to docs.yml

f66910e


          update demo notebook

3a8acaa


          include nbs explicitly

b3fab43


          shorten nb name

d0a8370


          fix some errors in the notebooks

201f68c


          correct path for cropposts ref

d1f5a8c

Member

iulusoy commented Oct 27, 2023

Update the demo notebook some more:

no more copying it in the CI, as some variables need to be set differently for the DemoNotebook in the docs/source folder.
there is an issue with the way summaryDetector is called in the DemoNotebook, can you please take a look?
The Demo notebook for multimodal search - is that up do date?

piterand added 3 commits

October 30, 2023 11:55


          fixed issues in DemoNotebook

5b2e006


          remove debug lines in summary

c436d9e


          changed append_data_to_dict to get_dataframe in notebooks

8effea7

sonarqubecloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

piterand merged commit fe1e937 into main

7 checks passed

piterand deleted the documentation_update branch

October 30, 2023 15:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet