Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RORDEV-1152] ES testcontainer fixes #1018

Merged
merged 1 commit into from
May 17, 2024
Merged

[RORDEV-1152] ES testcontainer fixes #1018

merged 1 commit into from
May 17, 2024

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented May 17, 2024 •
edited
Loading

Fixes:

  • ES container startup timeout was reduced to 1 minute, instead of intended 2 minutes, now restored to the 5 minutes default from before Scala 3 migration
  • testcontainers-scala downgraded back to 0.40.17 - I could not consistently reproduce it, but there may be a bug in 0.41.x, that manifests when using Dockerfile and copying files (testcontainers-java/issues/1348, testcontainers-java/issues/7239)

@mgoworko mgoworko marked this pull request as ready for review May 17, 2024 10:43
coutoPL
coutoPL approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coutoPL coutoPL merged commit ffb1efd into sscarduzio:epic/RORDEV-1152_scala3_migration May 17, 2024
1 check passed
coutoPL pushed a commit that referenced this pull request May 23, 2024
@mgoworko @coutoPL
Test ES container fixes (#1018)
75922da
@mgoworko mgoworko deleted the fix/RORDEV-1152-test-es-container-fixes branch May 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @coutoPL