Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] GR1 V6 Fix compliance status for single column UPN list #364

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Jan 14, 2025

Overview/Summary

This Pull Request fixes compliance status for the following:

  1. When the required file is uploaded with the correct headers but only included the highly privileged UPNs - GR1 | Validation 6 | Incorrect Compliance Status - Use Case for Missing Information in Second Column - Bug #331
  2. When the required file is uploaded with the correct headers but only included the regular UPNs - GR1 | Validation 6 | Incorrect Compliance Status - Use Case for Missing Information in First Column - Bug #332
  3. When the required file is uploaded with one header only and included the highly privileged UPNs
  4. When the required file is uploaded with one header only and included the regular UPNs
  5. When the required file is uploaded with both headers but headers and data has semicolon in-between, hence its read as single column csv

This PR fixes/adds/changes/removes

This pull request adds the logic for the above test cases

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 marked this pull request as ready for review January 14, 2025 19:09
@dutt0 dutt0 changed the title fix for single column list [Bugfix] GR1 V6 Fix compliance status for single column UPN list Jan 14, 2025
@dutt0 dutt0 merged commit beb5f81 into main Jan 15, 2025
4 checks passed
@dutt0 dutt0 deleted the idutta/GR1V6_one_column_csv branch January 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants