Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - Error in the Workbook for guardrails 1,2,3,4,5,6,7 #237

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

singhgss
Copy link
Contributor

Overview/Summary

This Pull Request fixes errors related to the workbook for guardrails 1, 2, 3, 4, 5, 6, and 7, but not for guardrails 8 and 9. Specifically, it addresses a type mismatch issue in the iff() function where the @then data type (real) did not match the @else data type (string). This PR ensures the correct data type is used for both the @then and @else conditions to avoid the workbook error.

This PR fixes/adds/changes/removes

Fixes #222

  1. Fixes the data type mismatch in the iff() function in the workbook for guardrails 1-7.
  2. Ensures the consistent use of data types across all workbook calculations.

Breaking Changes

None

Testing Evidence

Testing was performed by executing the workbook for all guardrails. Guardrails 1-7 now pass without error, and the correct
values are displayed. Screenshots are provided below:
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensured PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@singhgss singhgss changed the title Gsingh/fix workbook error mcu [BugFix]- Error in the Workbook for guardrails 1,2,3,4,5,6,7 Oct 11, 2024
@singhgss singhgss changed the title [BugFix]- Error in the Workbook for guardrails 1,2,3,4,5,6,7 [BugFix] - Error in the Workbook for guardrails 1,2,3,4,5,6,7 Oct 11, 2024
@singhgss singhgss merged commit e233e42 into main Oct 11, 2024
4 checks passed
@singhgss singhgss deleted the gsingh/fix-workbook-error-mcu branch October 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.1.0: Error in the Workbook for guardrails 1,2,3,4,5,6,7 but not for guardrails 8 and 9
2 participants